2597: Add epic relations #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tuj
requested changes
Jan 3, 2025
| $epic = new Epic(); | ||
| $epic->setTitle($epicTitle); | ||
| $this->entityManager->persist($epic); | ||
| $this->entityManager->flush(); |
src/Entity/IssueEpic.php
Outdated
| @@ -0,0 +1,17 @@ | |||
| <?php | |||
tuj
requested changes
Jan 3, 2025
| @@ -271,6 +274,26 @@ public function syncIssuesForProject(int $projectId, ?callable $progressCallback | |||
| } | |||
| } | |||
|
|
|||
| $epicArray = explode(',', $issueDatum->epicName); | |||
There was a problem hiding this comment.
Instead of exploding here, issueDatum should include an array of Epics, and LeantimeDataProvider and JiraDataProvider should supply the array of epics.
…g service initialization.
… from issueDatum.
…d persisting epics.
4 tasks
tuj
requested changes
Jan 6, 2025
src/Model/Invoices/IssueData.php
Outdated
| @@ -2,6 +2,7 @@ | |||
|
|
|||
| namespace App\Model\Invoices; | |||
|
|
|||
| use App\Entity\Epic; | |||
There was a problem hiding this comment.
I don't think we should mix Entity with Model.
The collection $epics could just be an array of strings instead. Then you can map to Epic entity in DataSynchronizationService.
src/Service/JiraApiService.php
Outdated
| @@ -53,6 +55,7 @@ public function __construct( | |||
| protected readonly float $weekGoalLow, | |||
| protected readonly float $weekGoalHigh, | |||
| protected readonly string $sprintNameRegex, | |||
| private readonly EpicRepository $epicRepository, | |||
There was a problem hiding this comment.
We should not do anything with Entities in the ApiServices.
Co-authored-by: Troels Ugilt Jensen <[email protected]>
Co-authored-by: Troels Ugilt Jensen <[email protected]>
Co-authored-by: Troels Ugilt Jensen <[email protected]>
Co-authored-by: Troels Ugilt Jensen <[email protected]>
Co-authored-by: Troels Ugilt Jensen <[email protected]>
Co-authored-by: Troels Ugilt Jensen <[email protected]>
…y-report Invoicing rate report
…iod-average-etc 3489: workload report period average + etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket
2597
Description
This PR adds relations for epics.
Screenshot of the result
N/A
Checklist